Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(uplift to 1.45.x) Updated text to Copy clean link #15606

Merged
merged 1 commit into from
Oct 24, 2022
Merged

(uplift to 1.45.x) Updated text to Copy clean link #15606

merged 1 commit into from
Oct 24, 2022

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Oct 22, 2022 •
edited by kjozwiak
Loading

Uplift of #15518
Resolves brave/brave-browser#26106
Resolves brave/brave-browser#25621

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@spylogsster spylogsster requested a review from a team as a code owner October 22, 2022 15:34
@spylogsster spylogsster self-assigned this Oct 22, 2022
@kjozwiak kjozwiak added this to the 1.45.x - Release milestone Oct 24, 2022
kjozwiak
kjozwiak approved these changes Oct 24, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.45.x approved 👍 QA has verified the PR on Nightly as per #15518 (comment).

@kjozwiak kjozwiak merged commit 1e9bbc1 into 1.45.x Oct 24, 2022
@kjozwiak kjozwiak deleted the 15518_uplift_to_1.45.x branch October 24, 2022 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@spylogsster spylogsster

Labels
None yet
Projects
None yet
Milestone
1.45.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@spylogsster @kjozwiak